-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance with semantic HTML5 #68
Conversation
- Add a little `time` here and there. - Add `kbd` elements to the explanation of access keys. - Some uses of the `kbd` element were used for commands, but these commands are themselves `code`. - Changed `<blockquote><pre>` to `<code><pre>`. - Update CSS.
**NOTE: Untested!** I don’t know how to set up a server to test these changes. I tried my best to be careful with the changes. ---- - Use `sections` to group each checked URL - Use a `data-url-checked` attribute on the `section` (to make scraping or client-side DOM manipulation easier) - Updated to use HTML5 `progress` element
@dontcallmedom Open to review this one? |
I write Perl every day - do you want me to check it? |
@halindrome Absolutely! Have it it :) 👍 |
@halindrome Is it working okay? |
@halindrome I take it work has got in the way? No worries. If you change your mind, it's probably a very simple review for someone who knows Perl. If not: Anyone else who knows #perl willing to review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - sorry for the delay!
@Zearin you marked this PR as draft - is it now ready to be merged from your perspective? |
@dontcallmedom If it works as intended, go for it! |
This needs to be properly tested!
I have barely used Perl, and even then…
That said, I tried to be careful with these changes, and I’m pretty sure everything should work out fine.
If it works, this will sprinkle a dash of modern markup into things. As a nice side effect, grouping each checked URL in its own
section
will make scraping or DOM-manipulating a long results list (an inevitability with recursive link checking) a little bit easier.